Fix crash on fullscreening of popup.

Fix crash on fullscreening of popup.

BUG=http://crbug.com/18551

TEST=Create a pop-up window.
Fullscreen it (Cmd-Shift-F).
Go back (Cmd-Shift-F again).
Repeat a few times across different launches of Chromium.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22712

[rohitrao (ping after 24h), 2009-08-06 00:12:54]

http://codereview.chromium.org/164024/diff/1/3
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/164024/diff/1/3#newcode208
Line 208: [locationBar_ release];
This scares me a bit, because it requires us to match calls to setHasToolbar:YES
and setHasToolbar:NO.  I would be happier just always retaining locationBar_ in
awakeFromNib and always releasing it in dealloc.

http://codereview.chromium.org/164024/diff/1/2
File chrome/browser/cocoa/toolbar_controller_unittest.mm (right):

http://codereview.chromium.org/164024/diff/1/2#newcode91
Line 91: // scoped_nsautorelease_pool to do it properly :-(
Will it work to create a new autoreleasepool just for this one line?

[John Grabowski, 2009-08-06 01:18:35]

New diff uploaded

http://codereview.chromium.org/164024/diff/1/3
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/164024/diff/1/3#newcode208
Line 208: [locationBar_ release];
On 2009/08/06 00:12:54, rohitrao wrote:
> This scares me a bit, because it requires us to match calls to
setHasToolbar:YES
> and setHasToolbar:NO.  I would be happier just always retaining locationBar_
in
> awakeFromNib and always releasing it in dealloc.

I don't want you frightened.
Wrapped in a scoped_nsobject.

http://codereview.chromium.org/164024/diff/1/2
File chrome/browser/cocoa/toolbar_controller_unittest.mm (right):

http://codereview.chromium.org/164024/diff/1/2#newcode91
Line 91: // scoped_nsautorelease_pool to do it properly :-(
On 2009/08/06 00:12:54, rohitrao wrote:
> Will it work to create a new autoreleasepool just for this one line?

No; I need to release the pool which existed when the AutocompleteTextField is
loaded.  That's the spot where it gets autoreleased.

[rohitrao (ping after 24h), 2009-08-06 01:27:39]

LGTM, but you need to add toolbar_controller.h.

Less scared now that we have the scoped_nsobject.