git_drover.py - Issue 1640233002: git-drover: Correctly resolve --parent_checkout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_drover.py

Issue 1640233002: git-drover: Correctly resolve --parent_checkout (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_drover.py

diff --git a/git_drover.py b/git_drover.py

index 9b4f6232e14c41dd2ee0b147d3ba37659392f176..ad6d0e13c745b7dc3e1e0c1983c52ac8339f84ef 100755

--- a/git_drover.py

+++ b/git_drover.py

@@ -227,7 +227,7 @@ class _Drover(object):

This is so the new workdir can be a sparse checkout without affecting

|self._parent_repo|.

"""

- parent_git_dir = os.path.abspath(self._run_git_command(

+ parent_git_dir = os.path.join(self._parent_repo, self._run_git_command(

['rev-parse', '--git-dir']).strip())

self._workdir = tempfile.mkdtemp(prefix='drover_%s_' % self._branch)

logging.debug('Creating checkout in %s', self._workdir)

« no previous file with comments | « no previous file | no next file » | no next file with comments »