Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1640233002: git-drover: Correctly resolve --parent_checkout (Closed)

Created:
4 years, 11 months ago by robwu
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Sam McNally
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git-drover: Correctly resolve --parent_checkout git rev-parse --git-dir returns a relative path, e.g. ".git". This should be resolved relative to the cwd of the git command instead of the current working dir. The cwd of the git command is set to _parent_repo (=the absolute path after resolving --parent_checkout), so use that. TEST=The following completes without errors. $ cd /tmp $ git init somegitrepo $ cd somegitrepo $ git drover --branch [branch] --cherry-pick [hash] -v --dry-run --parent_checkout /path/to/src $ cd /path/to/src $ git drover --branch [branch] --cherry-pick [hash] -v --dry-run Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_drover.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
robwu
4 years, 11 months ago (2016-01-27 13:00:01 UTC) #2
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-27 17:58:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640233002/1
4 years, 11 months ago (2016-01-27 19:20:21 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:22:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298416

Powered by Google App Engine
This is Rietveld 408576698