Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 164023007: Correctly handle any number of channels in WebAudio file decoder on Android (Closed)

Created:
6 years, 10 months ago by Raymond Toy (Google)
Modified:
6 years, 10 months ago
Reviewers:
qinmin
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Correctly handle any number of channels in WebAudio file decoder on Android. CopyPcmDataToBus incorrectly assumed that each pipe contained a integer number of frames. This is only true if the number of channels is 1 or 2. For more channels, this is false, so we have to copy the data carefully, keeping track of which sample in a frame we are in. BUG=343648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/renderer/media/android/audio_decoder_android.cc View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Raymond Toy (Google)
PTAL
6 years, 10 months ago (2014-02-19 17:52:47 UTC) #1
Raymond Toy (Google)
PTAL
6 years, 10 months ago (2014-02-19 18:06:36 UTC) #2
qinmin
lgtm
6 years, 10 months ago (2014-02-19 22:48:07 UTC) #3
Raymond Toy (Google)
On 2014/02/19 22:48:07, qinmin wrote: > lgtm Thanks
6 years, 10 months ago (2014-02-19 22:53:26 UTC) #4
Raymond Toy (Google)
The CQ bit was checked by rtoy@google.com
6 years, 10 months ago (2014-02-19 22:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/164023007/1
6 years, 10 months ago (2014-02-19 23:19:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/164023007/1
6 years, 10 months ago (2014-02-20 01:10:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/164023007/1
6 years, 10 months ago (2014-02-20 04:54:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/164023007/1
6 years, 10 months ago (2014-02-20 08:54:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/164023007/1
6 years, 10 months ago (2014-02-20 12:23:15 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 13:43:28 UTC) #11
Message was sent while issue was closed.
Change committed as 252223

Powered by Google App Engine
This is Rietveld 408576698