Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 164023004: Set default synthetic gesture source type on aura to be touch event (Closed)

Created:
6 years, 10 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Set default synthetic gesture source type on aura to be touch event Since we care touch scroll latency more than mouse wheel scroll latency, lets change the default gesture source type to be touch. If we need to monitor mouse wheel scroll latency in the future, we can then setup a new perf bot running telemetry smoothness test with mouse event selected. BUG=246034 TEST=telemetry smoothness test on CrOS now shows mean_touch_scroll_latency instead of mean_mouse_wheel_scroll_latency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Yufeng Shen (Slow to review)
6 years, 10 months ago (2014-02-18 22:37:18 UTC) #1
Dominik Grewe
LGTM
6 years, 10 months ago (2014-02-18 23:06:06 UTC) #2
Yufeng Shen (Slow to review)
+ Jared for OWNER.
6 years, 10 months ago (2014-02-19 00:16:16 UTC) #3
jdduke (slow)
lgtm
6 years, 10 months ago (2014-02-19 00:17:39 UTC) #4
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 10 months ago (2014-02-19 00:21:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/164023004/1
6 years, 10 months ago (2014-02-19 00:22:11 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:17:35 UTC) #7
Message was sent while issue was closed.
Change committed as 251962

Powered by Google App Engine
This is Rietveld 408576698