profiler: cleanup unused alternate_timer code

profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
Committed: https://crrev.com/bc5681f5a8d1db9c8a9d654531e1008b6065dbdd
Cr-Commit-Position: refs/heads/master@{#373286}

[Primiano Tucci (use gerrit), 2016-01-27 13:01:53]

primiano@chromium.org changed reviewers:
+ amistry@chromium.org, isherman@chromium.org

[Primiano Tucci (use gerrit), 2016-01-27 13:01:54]

Small cleanup, PTAL

[Anand Mistry (off Chromium), 2016-01-27 14:29:45]

On 2016/01/27 13:01:54, Primiano Tucci wrote:
> Small cleanup, PTAL

I don't have any stake in any of this code, and also don't have OWNERS. I
suggest picking someone else as a reviewer.

[Primiano Tucci (use gerrit), 2016-01-27 14:35:35]

primiano@chromium.org changed reviewers:
+ vadimt@chromium.org
- amistry@chromium.org

[Primiano Tucci (use gerrit), 2016-01-27 14:35:36]

On 2016/01/27 14:29:45, Anand Mistry wrote:
> On 2016/01/27 13:01:54, Primiano Tucci wrote:
> > Small cleanup, PTAL
> 
> I don't have any stake in any of this code, and also don't have OWNERS. I
> suggest picking someone else as a reviewer.

Apologies. I did try to pick folks who might know more using git blame, but I
realize now that I somehow copied/paste the wrong user.
I really meant +vadimt here.

vadimt are you familiar with object_tracker here? Just removing some stale code.

[vadimt, 2016-01-27 15:48:47]

On 2016/01/27 14:35:36, Primiano Tucci wrote:
> On 2016/01/27 14:29:45, Anand Mistry wrote:
> > On 2016/01/27 13:01:54, Primiano Tucci wrote:
> > > Small cleanup, PTAL
> > 
> > I don't have any stake in any of this code, and also don't have OWNERS. I
> > suggest picking someone else as a reviewer.
> 
> Apologies. I did try to pick folks who might know more using git blame, but I
> realize now that I somehow copied/paste the wrong user.
> I really meant +vadimt here.
> 
> vadimt are you familiar with object_tracker here? Just removing some stale
code.

Let's say that not anymore :)
isherman@ should be able to help you.

[vadimt, 2016-01-27 15:49:02]

Description was changed from

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
==========

to

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
==========

[vadimt, 2016-01-27 15:49:02]

vadimt@chromium.org changed reviewers:
- vadimt@chromium.org

[Ilya Sherman, 2016-01-28 01:36:46]

isherman@chromium.org changed reviewers:
+ jar@chromium.org

[Ilya Sherman, 2016-01-28 01:36:47]

(cc'ing jar@ as fyi)

Thanks for the cleanup!  I think there's an opportunity to remove some more code
along with this though -- PTAL.

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc
File base/tracked_objects.cc (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc#new...
base/tracked_objects.cc:46: static const bool kAllowAlternateTimeSourceHandling
= true;
Can this be removed?

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc#new...
base/tracked_objects.cc:756: }
Can this be removed?

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h
File base/tracked_objects.h (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h#newc...
base/tracked_objects.h:448: typedef unsigned int NowFunction();  // Type for an
alternate timer function.
Why is this needed?

[Primiano Tucci (use gerrit), 2016-01-28 10:46:36]

Thanks. Removing more code

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc
File base/tracked_objects.cc (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc#new...
base/tracked_objects.cc:46: static const bool kAllowAlternateTimeSourceHandling
= true;
On 2016/01/28 01:36:47, Ilya Sherman wrote:
> Can this be removed?

Yeah this sounds a "just in case" switch to make the code faster that we really
never used (also because it would break the ability of testing)

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.cc#new...
base/tracked_objects.cc:756: }
On 2016/01/28 01:36:47, Ilya Sherman wrote:
> Can this be removed?
Yes, I need to just keep now_function_ for the tests (renaming accordingly)

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h
File base/tracked_objects.h (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h#newc...
base/tracked_objects.h:448: typedef unsigned int NowFunction();  // Type for an
alternate timer function.
On 2016/01/28 01:36:47, Ilya Sherman wrote:
> Why is this needed?

This was previously in alternate_timer.h, which I am now removing.
The code below needs this.

[Ilya Sherman, 2016-01-29 01:23:14]

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h
File base/tracked_objects.h (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h#newc...
base/tracked_objects.h:448: typedef unsigned int NowFunction();  // Type for an
alternate timer function.
On 2016/01/28 10:46:36, Primiano Tucci wrote:
> On 2016/01/28 01:36:47, Ilya Sherman wrote:
> > Why is this needed?
> 
> This was previously in alternate_timer.h, which I am now removing.
> The code below needs this.

Is it just used for testing?  If so, let's not expose it as part of the public
API.

[Primiano Tucci (use gerrit), 2016-02-01 13:34:19]

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h
File base/tracked_objects.h (right):

https://codereview.chromium.org/1640223002/diff/1/base/tracked_objects.h#newc...
base/tracked_objects.h:448: typedef unsigned int NowFunction();  // Type for an
alternate timer function.
On 2016/01/29 01:23:14, Ilya Sherman wrote:
> On 2016/01/28 10:46:36, Primiano Tucci wrote:
> > On 2016/01/28 01:36:47, Ilya Sherman wrote:
> > > Why is this needed?
> > 
> > This was previously in alternate_timer.h, which I am now removing.
> > The code below needs this.
> 
> Is it just used for testing?  If so, let's not expose it as part of the public
> API.

Good point. Just testing. Done.

[Ilya Sherman, 2016-02-01 19:24:52]

LGTM.  Thanks for the cleanup =)

https://codereview.chromium.org/1640223002/diff/40001/base/tracked_objects.h
File base/tracked_objects.h (right):

https://codereview.chromium.org/1640223002/diff/40001/base/tracked_objects.h#...
base/tracked_objects.h:555: typedef unsigned int NowFunction();  // Type for an
alternate timer function.
nit: Mebbe update the comment to indicate that this is just used for testing.

[Primiano Tucci (use gerrit), 2016-02-02 09:40:06]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-02-02 09:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1640223002/#ps60001
(title: "doc")

[commit-bot: I haz the power, 2016-02-02 09:40:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640223002/60001

[commit-bot: I haz the power, 2016-02-02 09:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 09:49:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Primiano Tucci (use gerrit), 2016-02-03 10:42:15]

primiano@chromium.org changed reviewers:
+ thakis@chromium.org

[Primiano Tucci (use gerrit), 2016-02-03 10:42:15]

+thakis as base OWNER (TL;DR -131 lines from base/)

[Nico, 2016-02-03 17:05:35]

lgtm

[Primiano Tucci (use gerrit), 2016-02-03 17:11:12]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-03 17:12:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640223002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640223002/60001

[commit-bot: I haz the power, 2016-02-03 18:53:20]

Description was changed from

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
==========

to

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
==========

[commit-bot: I haz the power, 2016-02-03 18:53:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-03 18:54:41]

Description was changed from

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618
==========

to

==========
profiler: cleanup unused alternate_timer code

crrev.com/1632253002 removed the only client of alternate_timer.h
This CL removes the unreachable paths in the profiler code which
were there just to support alternate_timer (concretelly TCMALLOC).

BUG=564618

Committed: https://crrev.com/bc5681f5a8d1db9c8a9d654531e1008b6065dbdd
Cr-Commit-Position: refs/heads/master@{#373286}
==========

[commit-bot: I haz the power, 2016-02-03 18:54:42]

Patchset 4 (id:??) landed as
https://crrev.com/bc5681f5a8d1db9c8a9d654531e1008b6065dbdd
Cr-Commit-Position: refs/heads/master@{#373286}