Source/core/rendering/RenderBlockLineLayout.cpp - Issue 16402019: Remove clips where we can show that they are unnecessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 16402019: Remove clips where we can show that they are unnecessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add TestExpectations for layout test changes due to crbug.com/249478 Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBlockLineLayout.cpp

diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp

index 3f7af227e28a59bfea891dc6c1c80cadbd43d357..35b9bcf008069097b4f964babad0c0df317c31d3 100644

--- a/Source/core/rendering/RenderBlockLineLayout.cpp

+++ b/Source/core/rendering/RenderBlockLineLayout.cpp

@@ -3192,8 +3192,8 @@ void RenderBlock::addOverflowFromInlineChildren()

endPadding = 1;

for (RootInlineBox* curr = firstRootBox(); curr; curr = curr->nextRootBox()) {

addLayoutOverflow(curr->paddedLayoutOverflowRect(endPadding));

- if (!hasOverflowClip())

- addVisualOverflow(curr->visualOverflowRect(curr->lineTop(), curr->lineBottom()));

+ LayoutRect visualOverflowRect = curr->visualOverflowRect(curr->lineTop(), curr->lineBottom());

+ addVisualOverflow(visualOverflowRect, VisualOverflowClippedByContentsClip);

}

« Source/core/rendering/RenderBlock.cpp ('K') | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderBox.h » ('J')