Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 16402019: Remove clips where we can show that they are unnecessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: NeedsRebaseline for Mac Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 // Technically it's odd that we are incorporating the borders into layout ov erflow, which is only supposed to be about overflow from our 600 // Technically it's odd that we are incorporating the borders into layout ov erflow, which is only supposed to be about overflow from our
601 // descendant objects, but since tables don't support overflow:auto, this wo rks out fine. 601 // descendant objects, but since tables don't support overflow:auto, this wo rks out fine.
602 if (collapseBorders()) { 602 if (collapseBorders()) {
603 int rightBorderOverflow = width() + outerBorderRight() - borderRight(); 603 int rightBorderOverflow = width() + outerBorderRight() - borderRight();
604 int leftBorderOverflow = borderLeft() - outerBorderLeft(); 604 int leftBorderOverflow = borderLeft() - outerBorderLeft();
605 int bottomBorderOverflow = height() + outerBorderBottom() - borderBottom (); 605 int bottomBorderOverflow = height() + outerBorderBottom() - borderBottom ();
606 int topBorderOverflow = borderTop() - outerBorderTop(); 606 int topBorderOverflow = borderTop() - outerBorderTop();
607 IntRect borderOverflowRect(leftBorderOverflow, topBorderOverflow, rightB orderOverflow - leftBorderOverflow, bottomBorderOverflow - topBorderOverflow); 607 IntRect borderOverflowRect(leftBorderOverflow, topBorderOverflow, rightB orderOverflow - leftBorderOverflow, bottomBorderOverflow - topBorderOverflow);
608 if (borderOverflowRect != pixelSnappedBorderBoxRect()) { 608 if (borderOverflowRect != pixelSnappedBorderBoxRect()) {
609 addLayoutOverflow(borderOverflowRect); 609 addLayoutOverflow(borderOverflowRect);
610 addVisualOverflow(borderOverflowRect); 610 addVisualOverflow(borderOverflowRect, VisualOverflowNotClipped);
611 } 611 }
612 } 612 }
613 613
614 // Add overflow from our caption. 614 // Add overflow from our caption.
615 for (unsigned i = 0; i < m_captions.size(); i++) 615 for (unsigned i = 0; i < m_captions.size(); i++)
616 addOverflowFromChild(m_captions[i]); 616 addOverflowFromChild(m_captions[i]);
617 617
618 // Add overflow from our sections. 618 // Add overflow from our sections.
619 for (RenderTableSection* section = topSection(); section; section = sectionB elow(section)) 619 for (RenderTableSection* section = topSection(); section; section = sectionB elow(section))
620 addOverflowFromChild(section); 620 addOverflowFromChild(section);
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1440 { 1440 {
1441 ASSERT(cell->isFirstOrLastCellInRow()); 1441 ASSERT(cell->isFirstOrLastCellInRow());
1442 if (hasSameDirectionAs(cell->row())) 1442 if (hasSameDirectionAs(cell->row()))
1443 return style()->borderEnd(); 1443 return style()->borderEnd();
1444 1444
1445 return style()->borderStart(); 1445 return style()->borderStart();
1446 } 1446 }
1447 1447
1448 } 1448 }
OLDNEW
« Source/core/rendering/RenderOverflowTest.cpp ('K') | « Source/core/rendering/RenderOverflowTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698