Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 16402019: Remove clips where we can show that they are unnecessary. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: per jchaffraix Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 630
631 if (!isRoot()) { 631 if (!isRoot()) {
632 LayoutRect overflowBox = visualOverflowRect(); 632 LayoutRect overflowBox = visualOverflowRect();
633 flipForWritingMode(overflowBox); 633 flipForWritingMode(overflowBox);
634 overflowBox.inflate(maximalOutlineSize(paintInfo.phase)); 634 overflowBox.inflate(maximalOutlineSize(paintInfo.phase));
635 overflowBox.moveBy(adjustedPaintOffset); 635 overflowBox.moveBy(adjustedPaintOffset);
636 if (!overflowBox.intersects(paintInfo.rect)) 636 if (!overflowBox.intersects(paintInfo.rect))
637 return; 637 return;
638 } 638 }
639 639
640 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset); 640 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset, ForceCont entsClip);
641 paintObject(paintInfo, adjustedPaintOffset); 641 paintObject(paintInfo, adjustedPaintOffset);
642 if (pushedClip) 642 if (pushedClip)
643 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset); 643 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset);
644 } 644 }
645 645
646 void RenderTable::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffs et) 646 void RenderTable::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffs et)
647 { 647 {
648 PaintPhase paintPhase = paintInfo.phase; 648 PaintPhase paintPhase = paintInfo.phase;
649 if ((paintPhase == PaintPhaseBlockBackground || paintPhase == PaintPhaseChil dBlockBackground) && hasBoxDecorations() && style()->visibility() == VISIBLE) 649 if ((paintPhase == PaintPhaseBlockBackground || paintPhase == PaintPhaseChil dBlockBackground) && hasBoxDecorations() && style()->visibility() == VISIBLE)
650 paintBoxDecorations(paintInfo, paintOffset); 650 paintBoxDecorations(paintInfo, paintOffset);
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1440 { 1440 {
1441 ASSERT(cell->isFirstOrLastCellInRow()); 1441 ASSERT(cell->isFirstOrLastCellInRow());
1442 if (hasSameDirectionAs(cell->row())) 1442 if (hasSameDirectionAs(cell->row()))
1443 return style()->borderEnd(); 1443 return style()->borderEnd();
1444 1444
1445 return style()->borderStart(); 1445 return style()->borderStart();
1446 } 1446 }
1447 1447
1448 } 1448 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderOverflowTest.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698