Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1640173005: [Line Layout API] Convert another RootInlineBox use of layoutObject() (Closed)

Created:
4 years, 11 months ago by dgrogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pilgrim_google, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@2_RootInlineBox1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Convert another RootInlineBox use of layoutObject() Classes inside core/layout/ that need a reference to an InlineBox's layoutObject are being converted to use lineLayoutItem() so that we can rationalize access to the Layout tree. There are no functional changes. BUG=499321 Committed: https://crrev.com/e0a6f6e878ae366cc08cb634cc61288f033b7d58 Cr-Commit-Position: refs/heads/master@{#371945}

Patch Set 1 : without dependency patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/line/EllipsisBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
dgrogan
Emil or Levi, could you review this?
4 years, 11 months ago (2016-01-27 23:19:45 UTC) #4
leviw_travelin_and_unemployed
lgtm
4 years, 11 months ago (2016-01-27 23:30:26 UTC) #6
leviw_travelin_and_unemployed
Can you add the main BUG # line to all these CL's? :)
4 years, 11 months ago (2016-01-27 23:30:55 UTC) #8
dgrogan
On 2016/01/27 23:30:55, leviw wrote: > Can you add the main BUG # line to ...
4 years, 11 months ago (2016-01-27 23:31:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640173005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640173005/40001
4 years, 11 months ago (2016-01-27 23:33:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-28 00:52:56 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 01:16:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0a6f6e878ae366cc08cb634cc61288f033b7d58
Cr-Commit-Position: refs/heads/master@{#371945}

Powered by Google App Engine
This is Rietveld 408576698