Linux: make gfx::Canvas honor GTK font settings.

Linux: make gfx::Canvas honor GTK font settings.

BUG=18038
TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22555

[Daniel Erat, 2009-08-05 22:36:02]

http://codereview.chromium.org/164017/diff/1/2
File app/gfx/canvas_linux.cc (right):

http://codereview.chromium.org/164017/diff/1/2#newcode21
Line 21: static cairo_font_options_t* cairo_font_options = NULL;
Is there a better place to be doing this?  I could make it a static var in
DrawStringInt(), but it seems plausible that another method could need this
someday.  Am I going to cause Valgrind warnings with a one-time "leak" like
this?

[agl, 2009-08-05 22:45:57]

LGTM. The big hunk looked like duplicated code, but I guess the enum values are
all different so there's not a lot which can be done.

http://codereview.chromium.org/164017/diff/1/2
File app/gfx/canvas_linux.cc (right):

http://codereview.chromium.org/164017/diff/1/2#newcode21
Line 21: static cairo_font_options_t* cairo_font_options = NULL;
I think it's ok where it is. You shouldn't trigger valgrind warnings as long as
you don't lose the pointer to it.

[Daniel Erat, 2009-08-05 22:52:49]

On 2009/08/05 22:45:57, agl wrote:
> LGTM. The big hunk looked like duplicated code, but I guess the enum values
are
> all different so there's not a lot which can be done.

Thanks for the quick review!  Yeah, I was hoping I'd be able to reuse some of
the earlier code, but there's really not much there (and the logic is slightly
different -- Cairo uses an antialias setting with off/grayscale/subpixel values,
unlike GtkSettings or SkPaint).