Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1640123005: Revert of Have each SandboxedProcessLauncherDelegate maintain a zygote. (Closed)

Created:
4 years, 10 months ago by Greg K
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, rickyz+watch_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Have each SandboxedProcessLauncherDelegate maintain a zygote. (patchset #16 id:500001 of https://codereview.chromium.org/1532423003/ ) Reason for revert: This change has caused several performance concerns, and those needs to be addressed before we ship this. Because my focus is shifting to other goals for the time being, I am reverting this until it can be sped up and re-landed. Original issue's description: > Have each SandboxedProcessLauncherDelegate maintain a zygote. > > To improve component updates of PPAPI plugins, Chrome needs multiple zygotes. > This will allow the PPAPI zygote to be recreated when a plugin is updated. > This CL allows Chrome to maintain a zygote for each process type by having > each SandboxedProcessLauncherDelegate maintain a class which can communicate > with its respective zygote. This CL will be followed up with work to allow > customization of zygotes, which will give Chrome the improve component update > experience. > > BUG=569191 > > Committed: https://crrev.com/3c1e16b490255119b6f70f94d1716645e897b185 > Cr-Commit-Position: refs/heads/master@{#370488} > > Committed: https://crrev.com/afd49a83be5da2df6667a2afd14239d7783aff52 > Cr-Commit-Position: refs/heads/master@{#371042} TBR=mdempsky@chromium.org,thestig@chromium.org,avi@chromium.org,mseaborn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=569191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+611 lines, -847 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 4 chunks +1 line, -17 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/child_process_launcher.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/child_process_launcher.cc View 11 chunks +22 lines, -29 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 4 chunks +3 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +3 lines, -32 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 5 chunks +3 lines, -29 lines 0 comments Download
D content/browser/zygote_host/zygote_communication_linux.h View 1 chunk +0 lines, -92 lines 0 comments Download
D content/browser/zygote_host/zygote_communication_linux.cc View 1 chunk +0 lines, -460 lines 0 comments Download
D content/browser/zygote_host/zygote_handle_linux.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.h View 3 chunks +65 lines, -15 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 4 chunks +497 lines, -29 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/browser/zygote_handle_linux.h View 1 chunk +0 lines, -21 lines 0 comments Download
M content/public/browser/zygote_host_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/sandboxed_process_launcher_delegate.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/public/common/sandboxed_process_launcher_delegate.cc View 1 chunk +2 lines, -4 lines 0 comments Download
D content/public/common/zygote_handle.h View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Greg K
Created Revert of Have each SandboxedProcessLauncherDelegate maintain a zygote.
4 years, 10 months ago (2016-01-28 19:19:02 UTC) #1
mdempsky
lgtm
4 years, 10 months ago (2016-01-28 19:20:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640123005/1
4 years, 10 months ago (2016-01-28 19:21:04 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 19:24:21 UTC) #5
Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698