media/base/android/media_source_player_unittest.cc - Issue 1640123004: Propagate media session id into MediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_source_player_unittest.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc

Patch Set: Fix stray kDefaultMediaSessionID Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/base/android/media_source_player.cc ('k') | third_party/WebKit/public/platform/modules/mediasession/WebMediaSession.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_source_player_unittest.cc

diff --git a/media/base/android/media_source_player_unittest.cc b/media/base/android/media_source_player_unittest.cc

index 0ce01abf36b39ad56db7ddaa40cc30cc99c493c7..36fc6791543447c37bce6b9721e0dbc941d93dae 100644

--- a/media/base/android/media_source_player_unittest.cc

+++ b/media/base/android/media_source_player_unittest.cc

@@ -162,11 +162,13 @@ class MediaSourcePlayerTest : public testing::Test {

MediaSourcePlayerTest()

: manager_(&message_loop_),

demuxer_(new MockDemuxerAndroid(&message_loop_)),

- player_(0, &manager_,

+ player_(0,

+ &manager_,

base::Bind(&MockMediaPlayerManager::OnDecorderResourcesReleased,

base::Unretained(&manager_)),

scoped_ptr<DemuxerAndroid>(demuxer_),

- GURL()),

+ GURL(),

+ kDefaultMediaSessionId),

decoder_callback_hook_executed_(false),

surface_texture_a_is_next_(true) {}