media/base/android/media_codec_player.cc - Issue 1640123004: Propagate media session id into MediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_player.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc

Patch Set: Fix stray kDefaultMediaSessionID Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/android/media_codec_player.cc

diff --git a/media/base/android/media_codec_player.cc b/media/base/android/media_codec_player.cc

index 7eb96442319b7aa1a64c6492f1a25939ced50995..b5c3b1b4d4cfbfe0e7b99070d69d7411f0ce3cba 100644

--- a/media/base/android/media_codec_player.cc

+++ b/media/base/android/media_codec_player.cc

@@ -41,11 +41,13 @@ MediaCodecPlayer::MediaCodecPlayer(

base::WeakPtr<MediaPlayerManager> manager,

const OnDecoderResourcesReleasedCB& on_decoder_resources_released_cb,

scoped_ptr<DemuxerAndroid> demuxer,

- const GURL& frame_url)

+ const GURL& frame_url,

+ int media_session_id)

: MediaPlayerAndroid(player_id,

manager.get(),

on_decoder_resources_released_cb,

- frame_url),

+ frame_url,

+ media_session_id),

ui_task_runner_(base::ThreadTaskRunnerHandle::Get()),

demuxer_(std::move(demuxer)),

state_(kStatePaused),

« no previous file with comments | « media/base/android/media_codec_player.h ('k') | media/base/android/media_codec_player_unittest.cc » ('j') | no next file with comments »