chrome/browser/media/android/remote/remote_media_player_bridge.cc - Issue 1640123004: Propagate media session id into MediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/remote/remote_media_player_bridge.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc

Patch Set: Fix stray kDefaultMediaSessionID Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media/android/remote/remote_media_player_bridge.cc

diff --git a/chrome/browser/media/android/remote/remote_media_player_bridge.cc b/chrome/browser/media/android/remote/remote_media_player_bridge.cc

index bcb4dab3453d1985b88eacba41fd007e6ea6eb9e..af4069cdb94bd3f1eecb5ade5a9755bb5a85f31e 100644

--- a/chrome/browser/media/android/remote/remote_media_player_bridge.cc

+++ b/chrome/browser/media/android/remote/remote_media_player_bridge.cc

@@ -43,10 +43,15 @@ RemoteMediaPlayerBridge::RemoteMediaPlayerBridge(

const std::string& user_agent,

bool hide_url_log,

RemoteMediaPlayerManager* manager)

- : MediaPlayerAndroid(player_id,

- manager,

- base::Bind(&DoNothing),

- manager->GetLocalPlayer(player_id)->frame_url()),

+ : MediaPlayerAndroid(

+ player_id,

+ manager,

+ base::Bind(&DoNothing),

+ manager->GetLocalPlayer(player_id)->frame_url(),

+ // TODO(davve): Media session interaction with remote

+ // playback not defined. Use invalid session id for now.

+ // https://github.com/whatwg/mediasession/issues/123

+ media::kInvalidMediaSessionId),

width_(0),

height_(0),

hide_url_log_(hide_url_log),

« no previous file with comments | « no previous file | content/browser/media/android/browser_media_player_manager.cc » ('j') | no next file with comments »