Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 164012: NNTP: Fix window tooltip so that it is not shown out of place.... (Closed)

Created:
11 years, 4 months ago by arv (Not doing code reviews)
Modified:
9 years, 3 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

NNTP: Fix window tooltip so that it is not shown out of place. BUG=18529 TEST=The bug is hard to reproduce but it involved moving the mouse fast over the link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22567

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/resources/new_new_tab.js View 1 4 chunks +15 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
11 years, 4 months ago (2009-08-05 22:16:44 UTC) #1
Glen Murphy
OK + nit http://codereview.chromium.org/164012/diff/1001/4 File chrome/browser/resources/new_new_tab.js (right): http://codereview.chromium.org/164012/diff/1001/4#newcode1142 Line 1142: } else { // focus ...
11 years, 4 months ago (2009-08-06 00:05:25 UTC) #2
arv (Not doing code reviews)
http://codereview.chromium.org/164012/diff/1001/4 File chrome/browser/resources/new_new_tab.js (right): http://codereview.chromium.org/164012/diff/1001/4#newcode1142 Line 1142: } else { // focus On 2009/08/06 00:05:27, ...
11 years, 4 months ago (2009-08-06 00:18:50 UTC) #3
Glen Murphy
11 years, 4 months ago (2009-08-06 00:21:48 UTC) #4
Eh, it's something I just kept getting dinged on in my reviews, so I carried it
forward. If there's no source, LGTM.


On 2009/08/06 00:18:50, arv wrote:
> http://codereview.chromium.org/164012/diff/1001/4
> File chrome/browser/resources/new_new_tab.js (right):
> 
> http://codereview.chromium.org/164012/diff/1001/4#newcode1142
> Line 1142: } else { // focus
> On 2009/08/06 00:05:27, Glen Murphy wrote:
> > two spaces before //, I think
> 
> I've never seen that in any style guide. There is other code that only have
one
> space before the comment. I can update all those comments when/if I find the
> rule about this in the style guide.

Powered by Google App Engine
This is Rietveld 408576698