Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 164010: GTK: Rounded corner on status bubble. (Closed)

Created:
11 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : g_object_unref(gc); #

Patch Set 3 : Completely different implementation based on region instead of mask #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -28 lines) Patch
M chrome/browser/gtk/status_bubble_gtk.h View 1 2 1 chunk +12 lines, -5 lines 0 comments Download
M chrome/browser/gtk/status_bubble_gtk.cc View 1 2 5 chunks +108 lines, -23 lines 4 comments Download

Messages

Total messages: 11 (0 generated)
Elliot Glaysher
11 years, 4 months ago (2009-08-05 22:07:51 UTC) #1
tony
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode32 Line 32: // Factor to multiply degress by. Nit: typo? ...
11 years, 4 months ago (2009-08-05 22:23:08 UTC) #2
Evan Martin
+dean since I think he did something like this for the bookmarks buble
11 years, 4 months ago (2009-08-05 22:24:22 UTC) #3
Evan Stade
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode208 Line 208: gtk_widget_shape_combine_mask(widget(), mask, 0, 0); Seems it would be ...
11 years, 4 months ago (2009-08-05 22:24:31 UTC) #4
Elliot Glaysher
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode184 Line 184: GdkGC* gc = gdk_gc_new(GDK_DRAWABLE(mask)); On 2009/08/05 22:23:08, tony ...
11 years, 4 months ago (2009-08-05 22:41:39 UTC) #5
Evan Martin
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode208 Line 208: gtk_widget_shape_combine_mask(widget(), mask, 0, 0); On 2009/08/05 22:41:40, Elliot ...
11 years, 4 months ago (2009-08-05 22:52:08 UTC) #6
Evan Stade
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode208 Line 208: gtk_widget_shape_combine_mask(widget(), mask, 0, 0); On 2009/08/05 22:41:40, Elliot ...
11 years, 4 months ago (2009-08-05 22:56:47 UTC) #7
Elliot Glaysher
http://codereview.chromium.org/164010/diff/1/2 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1/2#newcode208 Line 208: gtk_widget_shape_combine_mask(widget(), mask, 0, 0); On 2009/08/05 22:52:08, Evan ...
11 years, 4 months ago (2009-08-05 22:57:51 UTC) #8
Elliot Glaysher
Different implementation. Take another look?
11 years, 4 months ago (2009-08-06 00:07:40 UTC) #9
Evan Martin
LGTM http://codereview.chromium.org/164010/diff/1008/11 File chrome/browser/gtk/status_bubble_gtk.cc (right): http://codereview.chromium.org/164010/diff/1008/11#newcode28 Line 28: // The roundedness of the edges of ...
11 years, 4 months ago (2009-08-06 18:05:38 UTC) #10
Evan Stade
11 years, 4 months ago (2009-08-06 18:28:08 UTC) #11
lg

Powered by Google App Engine
This is Rietveld 408576698