Issue 16401: F6 should do tabbing between frames. The current behaviour differs from IE/Sa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16401: F6 should do tabbing between frames. The current behaviour differs from IE/Sa... (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

F6 should do tabbing between frames. The current behaviour differs from IE/Safari they alternate focus between address bar and view. Chromium just focuses on the omnibar and stays there. This fix will match the behaviour like other browsers. BUG=372 (http://crbug.com/372) TEST=Pressed F6 continuously

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -2 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

I don't think we should do this; wrote my thoughts on the bug.

12 years ago (2008-12-20 22:28:28 UTC) #2

Mohamed Mansour (USE mhm)

12 years ago (2008-12-22 05:14:16 UTC) #3

On 2008/12/20 22:28:28, pkasting wrote:
> I don't think we should do this; wrote my thoughts on the bug.

I answered back and believe we should do this bug.

Expand Messages | Collapse Messages