Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 1640033002: XFA: Remove dead AddDoRecord code. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -38 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_edit.h View 2 chunks +2 lines, -5 lines 0 comments Download
M xfa/include/fxfa/fxfa.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-27 02:51:38 UTC) #2
Tom Sepez
LGTM.
4 years, 11 months ago (2016-01-28 00:12:38 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-28 02:22:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ffb03cc9aafeefddde57a68c9257cae9dc505c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698