src/hydrogen.cc - Issue 164003002: Fix polymorphic inlining of accessors in a test-context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 164003002: Fix polymorphic inlining of accessors in a test-context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index e59048a0b56c342ed4fe0bb72d819685e24cff85..51e77069b223461ca2533760c79011fdbd13e7fc 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5791,9 +5791,13 @@ void HOptimizedGraphBuilder::HandlePolymorphicNamedFieldAccess(

}

ASSERT(join != NULL);

- join->SetJoinId(ast_id);

- set_current_block(join);

- if (!ast_context()->IsEffect()) ast_context()->ReturnValue(Pop());

+ if (join->HasPredecessor()) {

+ join->SetJoinId(ast_id);

+ set_current_block(join);

+ if (!ast_context()->IsEffect()) ast_context()->ReturnValue(Pop());

+ } else {

+ set_current_block(NULL);

+ }

}

« no previous file with comments | « no previous file | test/mjsunit/regress/polymorphic-accessor-test-context.js » ('j') | no next file with comments »