Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 164002: Apply theme to incognito NTP.... (Closed)

Created:
11 years, 4 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Apply theme to incognito NTP. BUG= http://crbug.com/18480 TEST= Open incognito window. Note that NTP is themed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22613

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -8 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 2 3 4 chunks +46 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/resources/incognito_tab.html View 1 2 3 3 chunks +21 lines, -1 line 0 comments Download
A chrome/browser/resources/new_incognito_tab_theme.css View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Miranda Callahan
11 years, 4 months ago (2009-08-05 22:45:15 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/164002/diff/2012/12 File chrome/browser/dom_ui/dom_ui_theme_source.cc (right): http://codereview.chromium.org/164002/diff/2012/12#newcode173 Line 173: base::Time::Now().ToDoubleT())))); // $1 Glen just changed this to ...
11 years, 4 months ago (2009-08-05 22:52:49 UTC) #2
Miranda Callahan
Thanks for the quick review; please take another look. http://codereview.chromium.org/164002/diff/2012/12 File chrome/browser/dom_ui/dom_ui_theme_source.cc (right): http://codereview.chromium.org/164002/diff/2012/12#newcode173 Line ...
11 years, 4 months ago (2009-08-05 23:00:06 UTC) #3
arv (Not doing code reviews)
11 years, 4 months ago (2009-08-05 23:42:34 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698