Issue 1640006: [login_manager] throw the switch to in-chrome authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1640006: [login_manager] throw the switch to in-chrome authentication (Closed)

Created:
10 years, 8 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-os-reviews_chromium.org, Will Drewry

Visibility:
Public.

Description

[login_manager] throw the switch to in-chrome authentication This CL begins obsoleting pam_google. Instead of execing a setuid helper binary from within chrome that loads pam_google to do authentication, chrome talks to ClientLogin itself, and then does some other HTTP requests to fetch the user's google accounts cookies. BUG=314 TEST=ensure you've got this patch; try logging in. Also, ran desktopui_DoLogin, login_CryptohomeMounted, login_CryptohomeUnmounted, etc.

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	session_manager_setup.sh	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

On 2010/04/12 16:58:03, cmasone wrote: > ok, Dave, will and I got the hangs-on-first-login-sometimes bug ...

10 years, 8 months ago (2010-04-16 20:53:25 UTC) #2

LGTM let's move things forward.

Expand Messages | Collapse Messages