Fix swiftshader include in ui/gl/BUILD.gn

Fix swiftshader include in ui/gl/BUILD.gn

BUG=None

Committed: https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
Cr-Commit-Position: refs/heads/master@{#371798}

[pkotwicz, 2016-01-27 00:56:41]

pkotwicz@chromium.org changed reviewers:
+ kbr@chromium.org

[pkotwicz, 2016-01-27 00:56:42]

kbr@ can you please take a look?

I came across this when I was comparing the includes when building chrome with
GN and GYP

[Ken Russell (switch to Gerrit), 2016-01-27 01:16:42]

Surprising this went unnoticed this long. lgtm

[pkotwicz, 2016-01-27 01:48:08]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-01-27 01:48:10]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2016-01-27 15:50:51]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:51:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640003002/1

[commit-bot: I haz the power, 2016-01-27 16:22:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 16:24:15]

Description was changed from

==========
Fix swiftshader include in ui/gl/BUILD.gn

BUG=None
==========

to

==========
Fix swiftshader include in ui/gl/BUILD.gn

BUG=None

Committed: https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
Cr-Commit-Position: refs/heads/master@{#371798}
==========

[commit-bot: I haz the power, 2016-01-27 16:24:16]

Patchset 1 (id:??) landed as
https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
Cr-Commit-Position: refs/heads/master@{#371798}

[capn, 2016-01-27 18:55:23]

Description was changed from

==========
Fix swiftshader include in ui/gl/BUILD.gn

BUG=None

Committed: https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
Cr-Commit-Position: refs/heads/master@{#371798}
==========

to

==========
Fix swiftshader include in ui/gl/BUILD.gn

BUG=None

Committed: https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
Cr-Commit-Position: refs/heads/master@{#371798}
==========

[capn, 2016-01-27 18:55:32]

On 2016/01/27 16:24:16, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
> Cr-Commit-Position: refs/heads/master@{#371798}

[chromium-reviews, 2016-01-27 19:09:19]

That include directory doesn't even appear to exist any more:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/swifts...

That makes me wonder how Chrome is disabling the watermark logo rendering.
It's supposed to pass it a registration key:
https://swiftshader.googlesource.com/SwiftShader/+/master/include/software_re...

On Wed, Jan 27, 2016 at 1:55 PM, <capn@chromium.org> wrote:

> On 2016/01/27 16:24:16, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
> > Cr-Commit-Position: refs/heads/master@{#371798}
>
>
> https://codereview.chromium.org/1640003002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Russell (switch to Gerrit), 2016-01-27 20:06:31]

On 2016/01/27 19:09:19, chromium-reviews wrote:
> That include directory doesn't even appear to exist any more:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/swifts...

It's surely pulled in via the src-internal (non-public) repository.
 
> That makes me wonder how Chrome is disabling the watermark logo rendering.
> It's supposed to pass it a registration key:
>
https://swiftshader.googlesource.com/SwiftShader/+/master/include/software_re...
> 
> On Wed, Jan 27, 2016 at 1:55 PM, <mailto:capn@chromium.org> wrote:
> 
> > On 2016/01/27 16:24:16, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/65da625b34f3a2759e6167f6906202fc9a9a4c41
> > > Cr-Commit-Position: refs/heads/master@{#371798}
> >
> >
> > https://codereview.chromium.org/1640003002/
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.