Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 1639983002: Roll buildtools 222bd42ce3..11961c2151 (Closed)

Created:
4 years, 11 months ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 222bd42ce3..11961c2151 In order to roll GN 6a9b6b4394..16920f1d78 (r370714:r371631) and pick up the following changes: 81aa4e8 Add an assert_no_deps variable to GN. bf5ff79 Support for excluding variable from forwarding via forward_variables_form. TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/ba72dc924231c3a9defd7bf505d0afa50745ced4 Cr-Commit-Position: refs/heads/master@{#371670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
4 years, 11 months ago (2016-01-26 23:52:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639983002/1
4 years, 11 months ago (2016-01-26 23:52:32 UTC) #3
Dirk Pranke
we might want to land another CL to update //tools/gn/docs and roll to that instead, ...
4 years, 11 months ago (2016-01-27 00:35:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 01:19:41 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 01:21:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba72dc924231c3a9defd7bf505d0afa50745ced4
Cr-Commit-Position: refs/heads/master@{#371670}

Powered by Google App Engine
This is Rietveld 408576698