Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: content/shell/browser/layout_test/layout_test_devtools_frontend.cc

Issue 1639973003: [DevTools] use debug_frontend flag in content_shell for tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/layout_test_devtools_frontend.cc
diff --git a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
index 63a7809f015c0a93372c9a99a8e6899546319532..7a047dafcd2e6274f7b592c4190220b1a883a45c 100644
--- a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
+++ b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
@@ -53,10 +53,16 @@ GURL LayoutTestDevToolsFrontend::GetDevToolsPathAsURL(
dir_exe.AppendASCII("resources/inspector/inspector.html");
GURL result = net::FilePathToFileURL(dev_tools_path);
- if (!settings.empty())
- result = GURL(base::StringPrintf("%s?settings=%s&experiments=true",
- result.spec().c_str(),
- settings.c_str()));
+ if (!settings.empty()) {
+ std::string queryParams =
+ base::StringPrintf("%s?settings=%s&experiments=true",
+ result.spec().c_str(), settings.c_str());
+#if defined(DEBUG_DEVTOOLS)
+ queryParams += "&debugFrontend=true";
dgozman 2016/01/27 02:39:14 Should we append debugFrontend and experiments eve
kozy 2016/01/27 18:54:55 Done.
+#endif // defined(DEBUG_DEVTOOLS)
+
+ result = GURL(queryParams);
+ }
return result;
}
« no previous file with comments | « content/shell/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698