[DevTools] use debug_frontend flag in content_shell for tests

[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/6adbc801cf184198ff25da98ad68cc457f5497a2
Cr-Commit-Position: refs/heads/master@{#371919}

[kozy, 2016-01-27 02:18:16]

Dmitry, please take a look!

[dgozman, 2016-01-27 02:39:14]

lgtm

https://codereview.chromium.org/1639973003/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_devtools_frontend.cc (right):

https://codereview.chromium.org/1639973003/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_devtools_frontend.cc:61:
queryParams += "&debugFrontend=true";
Should we append debugFrontend and experiments even when no settings were
passed?

[kozy, 2016-01-27 18:54:55]

All done.

https://codereview.chromium.org/1639973003/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_devtools_frontend.cc (right):

https://codereview.chromium.org/1639973003/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_devtools_frontend.cc:61:
queryParams += "&debugFrontend=true";
On 2016/01/27 02:39:14, dgozman wrote:
> Should we append debugFrontend and experiments even when no settings were
> passed?

Done.

[kozy, 2016-01-27 18:56:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-01-27 18:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1639973003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-27 18:59:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639973003/20001

[commit-bot: I haz the power, 2016-01-27 19:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 19:11:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2016-01-27 19:24:30]

Description was changed from

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org
==========

to

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org
==========

[kozy, 2016-01-27 19:24:51]

Pavel, owner lgtm please!

[kozy, 2016-01-27 22:00:59]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 22:03:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639973003/20001

[pfeldman, 2016-01-27 22:34:15]

On 2016/01/27 22:03:43, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1639973003/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1639973003/20001

next time just add me to the list of reviewers!

lgtm

[kozy, 2016-01-27 22:59:53]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-01-27 22:59:58]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-01-27 23:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639973003/20001

[commit-bot: I haz the power, 2016-01-28 00:16:22]

Description was changed from

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-01-28 00:16:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 00:17:57]

Description was changed from

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] use debug_frontend flag in content_shell for tests

Without this flag InspectorFrontendHost can call callbacks while devtools on
pause. It makes debugging of layout tests useless.

R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/6adbc801cf184198ff25da98ad68cc457f5497a2
Cr-Commit-Position: refs/heads/master@{#371919}
==========

[commit-bot: I haz the power, 2016-01-28 00:18:03]

Patchset 2 (id:??) landed as
https://crrev.com/6adbc801cf184198ff25da98ad68cc457f5497a2
Cr-Commit-Position: refs/heads/master@{#371919}