chrome/renderer/resources/neterror.html - Issue 1639953002: Network error interstitial update - add suggestions list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/neterror.html

Issue 1639953002: Network error interstitial update - add suggestions list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up styling Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/neterror.css ('k') | components/error_page/common/localized_error.cc » ('j') | components/error_page/common/localized_error.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/neterror.html

diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html

index d5d435a1cf4230008934617aa5fbd630113ec024..27a729cf6b102797ca622803cda83797fa9ed6d3 100644

--- a/chrome/renderer/resources/neterror.html

+++ b/chrome/renderer/resources/neterror.html

@@ -19,6 +19,12 @@

+ <div id="suggestions-list" jsdisplay="(suggestionsList && suggestionsList.length)">

+ <p jsvalues=".innerHTML:suggestionListHeader"></p>

+ <ul jsvalues=".className:suggestionsList.length == 1 ? 'single-suggestion' : ''">

+ <li jsselect="suggestionsList" jsvalues=".innerHTML:summary" jsdisplay="summary"></li>

mmenke 2016/02/12 17:25:54 I don't think this jsdisplay gets us anything? At

edwardjung 2016/02/15 15:53:49 True, removed

+ </ul>

+ </div>

</div>

@@ -52,7 +58,7 @@

</div>

<button id="details-button" class="text-button small-link"

onclick="detailsButtonClick(); toggleHelpBox()" jscontent="details"

- jsdisplay="(suggestions && suggestions.length) || searchUrl || diagnose"

+ jsdisplay="(suggestions && suggestions.length > 0) || diagnose"

jsvalues=".detailsText:details; .hideDetailsText:hideDetails;"></button>

</div>

@@ -64,19 +70,6 @@

onclick="diagnoseErrors()" jscontent="diagnose"

jsdisplay="diagnose"></button>

- <form class="suggestions" jsdisplay="searchUrl"

- jsvalues=".url:searchUrl; .trackingId:searchTrackingId"

- onsubmit="trackClick(this.trackingId); return search(this.url);">

- <div class="suggestion-header" jscontent="searchHeader"></div>

- <div id="search-container">

- <input type="text" name="q" id="search-box"

- jsvalues=".value:searchTerms" />

- <button type="submit" id="search-button" class="blue-button"

- jsvalues="aria-label:searchHeader">

- <img id="search-image">

- </button>

- </div>

- </form>

</div>