src/IceInstARM32.cpp - Issue 1639923002: Subzero. ARM32. Vector lowering. Subtract.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1639923002: Subzero. ARM32. Vector lowering. Subtract. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index 03b65dd79cd2b9a2a71ea6c6e07b58abbc7f0bb5..5ef9c61d9a1dfaa0893dc4cd287e52b7c4b90e8c 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -651,13 +651,17 @@ template <> void InstARM32Vsub::emitIAS(const Cfg *Func) const {

Asm->setNeedsTextFixup();

John 2016/01/26 19:07:17 remove Asm->setNeedsTextFixup(); and invoke emitUs

Eric Holk 2016/01/26 22:56:38 Done.

break;

case IceType_f32:

+ assert(!Asm->needsTextFixup());

Asm->vsubs(getDest(), getSrc(0), getSrc(1), CondARM32::AL);

John 2016/01/26 19:07:17 move the assert below Asm->vsub()

Eric Holk 2016/01/26 22:56:38 Done.

break;

case IceType_f64:

+ assert(!Asm->needsTextFixup());

Asm->vsubd(getDest(), getSrc(0), getSrc(1), CondARM32::AL);

break;

}

- assert(!Asm->needsTextFixup());

+ if (Asm->needsTextFixup()) {

John 2016/01/26 19:07:17 remove this

Eric Holk 2016/01/26 22:56:38 Done.

+ emitUsingTextFixup(Func);

+ }

}

template <> void InstARM32Vmul::emitIAS(const Cfg *Func) const {

« src/IceInst.h ('K') | « src/IceInst.h ('k') | src/IceTargetLowering.h » ('j') | src/IceTargetLowering.h » ('J')