Subzero. ARM32. Vector lowering. Subtract.

src/IceInstARM32.cpp

 //===- subzero/src/IceInstARM32.cpp - ARM32 instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 630 matching lines @@
   Asm->veord(Dest, getSrc(0), getSrc(1));
   assert(!Asm->needsTextFixup());
 }
 
 template <> void InstARM32Vsub::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
   const Variable *Dest = getDest();
   switch (Dest->getType()) {
   default:
     // TODO(kschimpf) Figure if more cases are needed.
     Asm->setNeedsTextFixup();

[John, 2016/01/26 19:07:17]

remove Asm->setNeedsTextFixup(); and invoke emitUsingTextFixup() here.

[Eric Holk, 2016/01/26 22:56:38]

Done.

     break;
   case IceType_f32:
+    assert(!Asm->needsTextFixup());
     Asm->vsubs(getDest(), getSrc(0), getSrc(1), CondARM32::AL);

[John, 2016/01/26 19:07:17]

move the assert below Asm->vsub()

[Eric Holk, 2016/01/26 22:56:38]

Done.

     break;
   case IceType_f64:
+    assert(!Asm->needsTextFixup());
     Asm->vsubd(getDest(), getSrc(0), getSrc(1), CondARM32::AL);
     break;
   }
-  assert(!Asm->needsTextFixup());
+  if (Asm->needsTextFixup()) {

[John, 2016/01/26 19:07:17]

remove this

[Eric Holk, 2016/01/26 22:56:38]

Done.

+    emitUsingTextFixup(Func);
+  }
 }
 
 template <> void InstARM32Vmul::emitIAS(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
   const Variable *Dest = getDest();
   switch (Dest->getType()) {
   default:
     // TODO(kschimpf) Figure if more cases are needed.
     Asm->setNeedsTextFixup();
     break;
@@ skipping 1633 matching lines @@
 
 template class InstARM32FourAddrGPR<InstARM32::Mla>;
 template class InstARM32FourAddrGPR<InstARM32::Mls>;
 
 template class InstARM32CmpLike<InstARM32::Cmn>;
 template class InstARM32CmpLike<InstARM32::Cmp>;
 template class InstARM32CmpLike<InstARM32::Tst>;
 
 } // end of namespace ARM32
 } // end of namespace Ice