Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 16399007: Move runtime array constructor functions from builtins.cc to runtime.cc. (Closed)

Created:
7 years, 6 months ago by mvstanton
Modified:
7 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move runtime array constructor functions from builtins.cc to runtime.cc. Not only is runtime.cc a better location, but situations arise soon where we'll want to make runtime calls to these functions. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14977

Patch Set 1 #

Total comments: 8

Patch Set 2 : Comment updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -154 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D src/builtins-decls.h View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +101 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M test/mjsunit/fuzz-natives-part2.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Michael, here is (finally) the follow-up to the TODO we discussed, moving array constructor ...
7 years, 6 months ago (2013-06-06 11:45:50 UTC) #1
Michael Starzinger
Just a few nits for the runtime.cc file. https://codereview.chromium.org/16399007/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13505 src/runtime.cc:13505: RUNTIME_FUNCTION(MaybeObject*, ...
7 years, 6 months ago (2013-06-06 12:22:52 UTC) #2
mvstanton
Right on, thanks for the good look! --Michael https://codereview.chromium.org/16399007/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/16399007/diff/1/src/runtime.cc#newcode13505 src/runtime.cc:13505: RUNTIME_FUNCTION(MaybeObject*, ...
7 years, 6 months ago (2013-06-06 12:30:31 UTC) #3
Michael Starzinger
LGTM.
7 years, 6 months ago (2013-06-06 12:33:15 UTC) #4
mvstanton
7 years, 6 months ago (2013-06-06 13:22:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698