Add support for inline CSS in HTML files to CSS Presubmit checker

Add support for inline CSS in HTML files to CSS Presubmit checker

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None

Committed: https://crrev.com/ba1c4ef5402bcef911d1beb93ea7960124027213
Cr-Commit-Position: refs/heads/master@{#371710}

[tsergeant, 2016-01-27 01:24:54]

Description was changed from

==========
Add support for inline CSS in HTML files to CSS Presubmit checker

This allows <style> tags in HTML files to be checked for styleguide errors.

BUG=None
==========

to

==========
Add support for inline CSS in HTML files to CSS Presubmit checker

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None
==========

[tsergeant, 2016-01-27 01:28:25]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2016-01-27 01:28:26]

Please take a look!

[Dan Beam, 2016-01-27 02:50:45]

lgtm w/nits

overall: sweet!

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/css_checker.py (right):

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker.py:42: return '\n'.join(styles)
nit: to improve your code golf swing

  return '\n'.join(re.compile(r'<style>([^<]*)<\/style>').findall(s))

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker.py:387: file_contents =
_extract_inline_style(file_contents)
nit: \n

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/css_checker_test.py (right):

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker_test.py:43: def CreateFile(self,
contents, filename):
nit: this should probably be _create_file or __create_file (though this seems to
be less prevalent in Chrome)

https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker_test.py:48: def
VerifyContentsIsValid(self, contents, filename='fake.css'):
nit: "contents are" or "content is"

[tsergeant, 2016-01-27 03:12:14]

Thanks!

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/css_checker.py (right):

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker.py:42: return '\n'.join(styles)
On 2016/01/27 02:50:45, Dan Beam wrote:
> nit: to improve your code golf swing
> 
>   return '\n'.join(re.compile(r'<style>([^<]*)<\/style>').findall(s))

Done, one-upping by getting rid of the compile.

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker.py:387: file_contents =
_extract_inline_style(file_contents)
On 2016/01/27 02:50:45, Dan Beam wrote:
> nit: \n

Done.

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/css_checker_test.py (right):

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker_test.py:43: def CreateFile(self,
contents, filename):
On 2016/01/27 02:50:45, Dan Beam wrote:
> nit: this should probably be _create_file or __create_file (though this seems
to
> be less prevalent in Chrome)
> 
> https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

Done.

https://codereview.chromium.org/1639863004/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/css_checker_test.py:48: def
VerifyContentsIsValid(self, contents, filename='fake.css'):
On 2016/01/27 02:50:45, Dan Beam wrote:
> nit: "contents are" or "content is"

Done.

[tsergeant, 2016-01-27 03:12:30]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-01-27 03:12:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1639863004/#ps20001
(title: "Review comments")

[commit-bot: I haz the power, 2016-01-27 03:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639863004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639863004/20001

[commit-bot: I haz the power, 2016-01-27 03:44:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 03:47:10]

Description was changed from

==========
Add support for inline CSS in HTML files to CSS Presubmit checker

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None
==========

to

==========
Add support for inline CSS in HTML files to CSS Presubmit checker

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None

Committed: https://crrev.com/ba1c4ef5402bcef911d1beb93ea7960124027213
Cr-Commit-Position: refs/heads/master@{#371710}
==========

[commit-bot: I haz the power, 2016-01-27 03:47:11]

Patchset 2 (id:??) landed as
https://crrev.com/ba1c4ef5402bcef911d1beb93ea7960124027213
Cr-Commit-Position: refs/heads/master@{#371710}