try plain-old code for sk_memset16/32 now that NEON is compile-time

try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639863002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/3bc2624a4b89c49efd65f5e548ac5f2dd9351431

[mtklein_C, 2016-01-26 15:11:32]

Description was changed from

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

these implementations should autovectorize

BUG=skia:
==========

to

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

these implementations should autovectorize

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-02-17 19:17:41]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 19:17:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639863002/60001

[commit-bot: I haz the power, 2016-02-17 19:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 19:53:36]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-02-17 19:55:45]

Description was changed from

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

these implementations should autovectorize

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein, 2016-02-17 19:55:59]

Description was changed from

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-02-17 19:56:19]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[reed1, 2016-02-17 20:06:53]

do we have existing nanobenches to verify that we get about the same speed?

[mtklein, 2016-02-17 20:26:40]

On 2016/02/17 20:06:53, reed1 wrote:
> do we have existing nanobenches to verify that we get about the same speed?

Yes, https://perf.skia.org/#4899

[reed1, 2016-02-17 22:19:23]

that link did not work for me, but perhaps because I'm wfh.
lgtm

[mtklein, 2016-02-17 22:20:27]

On 2016/02/17 22:19:23, reed1 wrote:
> that link did not work for me, but perhaps because I'm wfh.
> lgtm

That's weird, it's a public link.  Works from my house.

[mtklein, 2016-02-17 22:20:31]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-02-17 22:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1639863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1639863002/60001

[commit-bot: I haz the power, 2016-02-17 22:21:30]

Description was changed from

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
try plain-old code for sk_memset16/32 now that NEON is compile-time

Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/3bc2624a4b89c49efd65f5e548ac5f2dd9351431
==========

[commit-bot: I haz the power, 2016-02-17 22:21:31]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3bc2624a4b89c49efd65f5e548ac5f2dd9351431