Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1639833002: Update yandex search urls to use https. (Closed)

Created:
4 years, 11 months ago by Alexander Yashkin
Modified:
4 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, vasilii+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update yandex search urls to use https. R=pkasting@chromium.org Committed: https://crrev.com/42d3b8e6bb06471800b866c0c6087eed823b5421 Cr-Commit-Position: refs/heads/master@{#371754}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Increment prepopulated engines version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M components/search_engines/prepopulated_engines.json View 1 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alexander Yashkin
4 years, 11 months ago (2016-01-26 12:19:28 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/1639833002/diff/1/components/search_engines/prepopulated_engines.json File components/search_engines/prepopulated_engines.json (right): https://codereview.chromium.org/1639833002/diff/1/components/search_engines/prepopulated_engines.json#newcode33 components/search_engines/prepopulated_engines.json:33: "kCurrentDataVersion": 88 You need to bump this number.
4 years, 11 months ago (2016-01-26 15:57:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639833002/20001
4 years, 11 months ago (2016-01-27 07:15:20 UTC) #5
Alexander Yashkin
On 2016/01/26 15:57:23, Peter Kasting wrote: > LGTM > > https://codereview.chromium.org/1639833002/diff/1/components/search_engines/prepopulated_engines.json > File components/search_engines/prepopulated_engines.json (right): ...
4 years, 11 months ago (2016-01-27 07:16:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 08:00:29 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 08:01:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42d3b8e6bb06471800b866c0c6087eed823b5421
Cr-Commit-Position: refs/heads/master@{#371754}

Powered by Google App Engine
This is Rietveld 408576698