Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 163983003: Exclude Signed Certificate Timestamps viewer strings. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude Signed Certificate Timestamps viewer strings. SCTs viewer is only used by Views and should not be included in other platforms. TBR=newt BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -88 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +90 lines, -88 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
Hey Eran, Please take a look at this change. Thanks, Aurimas
6 years, 10 months ago (2014-02-13 18:12:10 UTC) #1
Eran M. (Google)
LGTM - I will exclude my strings from mobile platforms in the future.
6 years, 10 months ago (2014-02-13 18:32:09 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-13 18:34:30 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 18:36:28 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 18:36:29 UTC) #5
aurimas (slooooooooow)
+newt for OWNERs review.
6 years, 10 months ago (2014-02-13 18:39:05 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-14 02:38:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/163983003/1
6 years, 10 months ago (2014-02-14 02:42:20 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 07:22:44 UTC) #9
Message was sent while issue was closed.
Change committed as 251266

Powered by Google App Engine
This is Rietveld 408576698