Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 163983002: SkWriter32: throw in the SkTDArray towel. (Closed)

Created:
6 years, 10 months ago by mtklein_C
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SkWriter32: throw in the SkTDArray towel. I think it's looking more clear we don't have a clean way to use SkTDArray in SkWriter32. We can't give SkWriter32 meaningful control over SkTDArray's reallocation without making moot SkTDArray's raison d'etre. Let's just use an SkAutoTMalloc<uint8_t> instead. It wants SkWriter32 to control it. Also, it's lower overhead: SkAutoTMalloc<uint8_t> is just a smart poiter: no size or capacity stored. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13436

Patch Set 1 #

Patch Set 2 : Clean up scars in SkTDArray. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -54 lines) Patch
M include/core/SkTDArray.h View 1 4 chunks +6 lines, -34 lines 0 comments Download
M include/core/SkWriter32.h View 3 chunks +7 lines, -12 lines 0 comments Download
M src/core/SkWriter32.cpp View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein_C
After seeing http://crrev.com/161063022, I'm starting to think our quest to unify this stuff is more ...
6 years, 10 months ago (2014-02-13 16:53:57 UTC) #1
reed2
lgtm
6 years, 10 months ago (2014-02-13 16:57:32 UTC) #2
mtklein_C
On 2014/02/13 16:57:32, reed2 wrote: > lgtm I just removed the newly dead API from ...
6 years, 10 months ago (2014-02-13 17:11:40 UTC) #3
reed2
lgtm
6 years, 10 months ago (2014-02-13 17:52:44 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 10 months ago (2014-02-13 17:59:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 17:59:16 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-13 17:59:17 UTC) #7
reed1
lgtm
6 years, 10 months ago (2014-02-13 18:06:24 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-13 18:06:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/163983002/40001
6 years, 10 months ago (2014-02-13 18:06:37 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 18:35:59 UTC) #11
Message was sent while issue was closed.
Change committed as 13436

Powered by Google App Engine
This is Rietveld 408576698