Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(201)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tools/clang/rewrite_to_chrome_style/CMakeLists.txt
Issue
1639663003
:
Clean up rewrite_to_chrome_style naming logic. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comprehensive fixes
Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
tools/clang/CMakeLists.txt
tools/clang/rewrite_to_chrome_style/CMakeLists.txt
tools/clang/rewrite_to_chrome_style/Renamer.h
tools/clang/rewrite_to_chrome_style/Renamer.cpp
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc
tools/clang/rewrite_to_chrome_style/tests/variables-original.cc
View unified diff
|
Download patch
« no previous file with comments
|
« tools/clang/CMakeLists.txt
('k') |
tools/clang/rewrite_to_chrome_style/Renamer.h »
('j') |
tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 set(LLVM_LINK_COMPONENTS
1 set(LLVM_LINK_COMPONENTS
2 BitReader
2 BitReader
3 MCParser
3 MCParser
4 Option
4 Option
5 X86AsmParser
5 X86AsmParser
6 X86CodeGen
6 X86CodeGen
7 )
7 )
8
8
9 add_llvm_executable(rewrite_to_chrome_style
9 add_llvm_executable(rewrite_to_chrome_style
10
Renamer.cpp
10 RewriteToChromeStyle.cpp
11 RewriteToChromeStyle.cpp
11 )
12 )
12
13
13 target_link_libraries(rewrite_to_chrome_style
14 target_link_libraries(rewrite_to_chrome_style
14 clangAST
15 clangAST
15 clangASTMatchers
16 clangASTMatchers
16 clangAnalysis
17 clangAnalysis
17 clangBasic
18 clangBasic
18 clangDriver
19 clangDriver
19 clangEdit
20 clangEdit
20 clangFrontend
21 clangFrontend
21 clangLex
22 clangLex
22 clangParse
23 clangParse
23 clangSema
24 clangSema
24 clangSerialization
25 clangSerialization
25 clangTooling
26 clangTooling
26 )
27 )
27
28
28 cr_install(TARGETS rewrite_to_chrome_style RUNTIME DESTINATION bin)
29 cr_install(TARGETS rewrite_to_chrome_style RUNTIME DESTINATION bin)
OLD
NEW
« no previous file with comments
|
« tools/clang/CMakeLists.txt
('k') |
tools/clang/rewrite_to_chrome_style/Renamer.h »
('j') |
tools/clang/rewrite_to_chrome_style/tests/variables-expected.cc »
('J')
Issue 1639663003: Clean up rewrite_to_chrome_style naming logic. (Closed)
Created 4 years, 11 months ago by dcheng
Modified 4 years, 10 months ago
Reviewers: danakj
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 9
This is Rietveld
408576698
Chromium Code Reviews
Issue 1639663003:
Clean up rewrite_to_chrome_style naming logic. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master