Clean up rewrite_to_chrome_style naming logic.

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 15 matching lines @@
 #include "clang/ASTMatchers/ASTMatchersMacros.h"
 #include "clang/Basic/CharInfo.h"
 #include "clang/Basic/SourceManager.h"
 #include "clang/Frontend/FrontendActions.h"
 #include "clang/Lex/Lexer.h"
 #include "clang/Tooling/CommonOptionsParser.h"
 #include "clang/Tooling/Refactoring.h"
 #include "clang/Tooling/Tooling.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/TargetSelect.h"
+#include "tools/clang/rewrite_to_chrome_style/Renamer.h"
 
 using namespace clang::ast_matchers;
 using clang::tooling::CommonOptionsParser;
 using clang::tooling::Replacement;
 using clang::tooling::Replacements;
 using llvm::StringRef;
 
 namespace {
 
 AST_MATCHER(clang::FunctionDecl, isOverloadedOperator) {
   return Node.isOverloadedOperator();
 }
 
 constexpr char kBlinkFieldPrefix[] = "m_";
 constexpr char kBlinkStaticMemberPrefix[] = "s_";
 
 bool GetNameForDecl(const clang::FunctionDecl& decl, std::string& name) {
-  name = decl.getNameAsString();
-  name[0] = clang::toUppercase(name[0]);
+  name = IdentifierToCamelCase(decl.getName());
   return true;
 }
 
-// Helper to convert from a camelCaseName to camel_case_name. It uses some
-// heuristics to try to handle acronyms in camel case names correctly.
-std::string CamelCaseToUnderscoreCase(StringRef input) {
-  std::string output;
-  bool needs_underscore = false;
-  bool was_lowercase = false;
-  bool was_uppercase = false;
-  // Iterate in reverse to minimize the amount of backtracking.
-  for (const unsigned char* i = input.bytes_end() - 1; i >= input.bytes_begin();
-       --i) {
-    char c = *i;
-    bool is_lowercase = clang::isLowercase(c);
-    bool is_uppercase = clang::isUppercase(c);
-    c = clang::toLowercase(c);
-    // Transitioning from upper to lower case requires an underscore. This is
-    // needed to handle names with acronyms, e.g. handledHTTPRequest needs a '_'
-    // in 'dH'. This is a complement to the non-acronym case further down.
-    if (needs_underscore || (was_uppercase && is_lowercase)) {
-      output += '_';
-      needs_underscore = false;
-    }
-    output += c;
-    // Handles the non-acronym case: transitioning from lower to upper case
-    // requires an underscore when emitting the next character, e.g. didLoad
-    // needs a '_' in 'dL'.
-    if (i != input.bytes_end() - 1 && was_lowercase && is_uppercase)
-      needs_underscore = true;
-    was_lowercase = is_lowercase;
-    was_uppercase = is_uppercase;
-  }
-  std::reverse(output.begin(), output.end());
-  return output;
-}
-
 bool GetNameForDecl(const clang::FieldDecl& decl, std::string& name) {
   StringRef original_name = decl.getName();
   // Blink style field names are prefixed with `m_`. If this prefix isn't
   // present, assume it's already been converted to Google style.
   if (original_name.size() < strlen(kBlinkFieldPrefix) ||
       !original_name.startswith(kBlinkFieldPrefix))
     return false;
-  name = CamelCaseToUnderscoreCase(
+  name = IdentifierToUnderscoreCase(
       original_name.substr(strlen(kBlinkFieldPrefix)));
   // The few examples I could find used struct-style naming with no `_` suffix
   // for unions.
   if (decl.getParent()->isClass())
     name += '_';
   return true;
 }
 
 bool IsProbablyConst(const clang::VarDecl& decl) {
   clang::QualType type = decl.getType();
@@ skipping 45 matching lines @@
     original_name = original_name.substr(strlen(kBlinkStaticMemberPrefix));
   else if (original_name.startswith(kBlinkFieldPrefix))
     original_name = original_name.substr(strlen(kBlinkFieldPrefix));
 
   if (IsProbablyConst(decl)) {
     // Don't try to rename constants that already conform to Chrome style.
     if (original_name.size() >= 2 && original_name[0] == 'k' &&
         clang::isUppercase(original_name[1]))
       return false;
     name = 'k';
-    name.append(original_name.data(), original_name.size());
-    name[1] = clang::toUppercase(name[1]);
+    name += IdentifierToCamelCase(original_name);
   } else {
-    name = CamelCaseToUnderscoreCase(original_name);
+    name = IdentifierToUnderscoreCase(original_name);
   }
 
   if (decl.isStaticDataMember()) {
     name += '_';
   }
 
   return true;
 }
 
 template <typename Type>
@@ skipping 356 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }