Fix prerender byte-count UMA.

Fix prerender byte-count UMA.

In the review process of cr/160513002 I wound up losing reports of bytes from non-prerender resources.  This fixes that.  It also updates the max bin size of profile bytes since there could be lots of requests between prerenders.

BUG=334602
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252125

[jkarlin, 2014-02-18 15:15:28]

tburkard@chromium.org: Please review changes in everything.

jochen@chromium.org: Please review changes in everything, but mostly for OWNERS.

[tburkard, 2014-02-18 15:16:53]

can you upload this again, can't see the changes in the web ui

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jkarlin, 2014-02-18 15:29:13]

Huh, weird.  Uploaded again and all is well.


On Tue, Feb 18, 2014 at 10:16 AM, Timo Burkard <tburkard@chromium.org>wrote:

> can you upload this again, can't see the changes in the web ui
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tburkard, 2014-02-18 15:31:28]

ah yup, good catch.

lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jkarlin, 2014-02-19 16:52:04]

PTAL jochen, thanks! :)

[jochen (gone - plz use gerrit), 2014-02-19 16:54:24]

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:137: if
(!render_view_host)
when is that possible?

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:147:
return NULL;
or this?

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:151:
return NULL;
or this?

[jkarlin, 2014-02-19 17:31:57]

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:137: if
(!render_view_host)
On 2014/02/19 16:54:24, jochen wrote:
> when is that possible?

Nearly everything that calls RenderViewHost::FromID checks for NULL.

It seems feasible to me that the RVH might go away between the renderer issuing
a request and the RDH switching to the UI thread to get here.

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:147:
return NULL;
On 2014/02/19 16:54:24, jochen wrote:
> or this?

Done.

https://codereview.chromium.org/163963005/diff/120001/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:151:
return NULL;
On 2014/02/19 16:54:24, jochen wrote:
> or this?

Done.

[jochen (gone - plz use gerrit), 2014-02-19 18:02:35]

lgtm

[jkarlin, 2014-02-19 18:08:38]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-02-19 18:15:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jkarlin@chromium.org/163963005/310001

[commit-bot: I haz the power, 2014-02-19 23:14:50]

Change committed as 252125