Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/a64/stub-cache-a64.cc

Issue 163963003: Remove unnecessary checks in CompileStoreInterceptor on a64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 #define __ ACCESS_MASM(masm()) 1286 #define __ ACCESS_MASM(masm())
1287 1287
1288 1288
1289 Handle<Code> StoreStubCompiler::CompileStoreInterceptor( 1289 Handle<Code> StoreStubCompiler::CompileStoreInterceptor(
1290 Handle<JSObject> object, 1290 Handle<JSObject> object,
1291 Handle<Name> name) { 1291 Handle<Name> name) {
1292 Label miss; 1292 Label miss;
1293 1293
1294 ASM_LOCATION("StoreStubCompiler::CompileStoreInterceptor"); 1294 ASM_LOCATION("StoreStubCompiler::CompileStoreInterceptor");
1295 1295
1296 // Check that the map of the object hasn't changed.
1297 __ CheckMap(receiver(), scratch1(), Handle<Map>(object->map()), &miss,
1298 DO_SMI_CHECK);
1299
1300 // Perform global security token check if needed.
1301 if (object->IsJSGlobalProxy()) {
1302 __ CheckAccessGlobalProxy(receiver(), scratch1(), &miss);
1303 }
1304
1305 // Stub is never generated for non-global objects that require access checks.
1306 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
1307
1308 __ Push(receiver(), this->name(), value()); 1296 __ Push(receiver(), this->name(), value());
1309 1297
1310 // Do tail-call to the runtime system. 1298 // Do tail-call to the runtime system.
1311 ExternalReference store_ic_property = 1299 ExternalReference store_ic_property =
1312 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate()); 1300 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate());
1313 __ TailCallExternalReference(store_ic_property, 3, 1); 1301 __ TailCallExternalReference(store_ic_property, 3, 1);
1314 1302
1315 // Handle store cache miss.
1316 __ Bind(&miss);
1317 TailCallBuiltin(masm(), MissBuiltin(kind()));
1318
1319 // Return the generated code. 1303 // Return the generated code.
1320 return GetCode(kind(), Code::FAST, name); 1304 return GetCode(kind(), Code::FAST, name);
1321 } 1305 }
1322 1306
1323 1307
1324 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type, 1308 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type,
1325 Handle<JSObject> last, 1309 Handle<JSObject> last,
1326 Handle<Name> name) { 1310 Handle<Name> name) {
1327 NonexistentHandlerFrontend(type, last, name); 1311 NonexistentHandlerFrontend(type, last, name);
1328 1312
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1551 1535
1552 // Miss case, call the runtime. 1536 // Miss case, call the runtime.
1553 __ Bind(&miss); 1537 __ Bind(&miss);
1554 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1538 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1555 } 1539 }
1556 1540
1557 1541
1558 } } // namespace v8::internal 1542 } } // namespace v8::internal
1559 1543
1560 #endif // V8_TARGET_ARCH_A64 1544 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698