Issue 163963002: Revert 251029 "Move Windows-specific code into NativeAppWindowVi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163963002: Revert 251029 "Move Windows-specific code into NativeAppWindowVi..." (Closed)

Created:
6 years, 10 months ago by Alexei Svitkine (slow)

Modified:
6 years, 10 months ago

Reviewers:
tmdiep

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 251029 "Move Windows-specific code into NativeAppWindowVi..." > Move Windows-specific code into NativeAppWindowViewsWin > > NativeAppWindowViews has Windows-specific code in #ifdefs. Move this > into derived class NativeAppWindowViewsWin. > > BUG=None > > Review URL: https://codereview.chromium.org/161753002 Broke windows build: c:\b\build\slave\win\build\src\chrome\browser\ui\views\apps\native_app_window_views_win.cc(36) : error C2027: use of undefined type 'base::SequencedWorkerPool' c:\b\build\slave\win\build\src\base\threading\thread_restrictions.h(82) : see declaration of 'base::SequencedWorkerPool' c:\b\build\slave\win\build\src\chrome\browser\ui\views\apps\native_app_window_views_win.cc(36) : error C2227: left of '->RunsTasksOnCurrentThread' must point to class/struct/union/generic type TBR=tmdiep@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251063

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -112 lines)			Patch
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views.h	View	3 chunks	+14 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc	View	4 chunks	+86 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views_win.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/apps/native_app_window_views_win.cc	View	3 chunks	+1 line, -96 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

6 years, 10 months ago (2014-02-13 16:45:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r251063 (tree was closed).

Expand Messages | Collapse Messages