ScreenWin Testability and Restructuring

ui/gfx/test/display_util.h

Index: ui/gfx/test/display_util.h
diff --git a/ui/gfx/test/display_util.h b/ui/gfx/test/display_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..842af7fdf9980cbfafe084cedec615bbb7de8888
--- /dev/null
+++ b/ui/gfx/test/display_util.h
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_TEST_DISPLAY_UTIL_H_
+#define UI_GFX_TEST_DISPLAY_UTIL_H_
+
+#include "ui/gfx/display.h"
+
+namespace gfx {

[oshima, 2016/01/30 00:10:33]

namespace test


namespace is meaningless for operator but it'll be useful if we add new function
in the future.

[robliao, 2016/01/30 01:23:52]

Oddly enough, it does matter. 
http://stackoverflow.com/questions/5195512/namespaces-and-operator-resolution

The compiler can't find the operator otherwise.

[oshima, 2016/02/01 19:07:37]

interesting, thanks for the pointer. 

+
+inline bool operator==(const gfx::Display& lhs, const gfx::Display& rhs) {
+  return lhs.id() == rhs.id() &&
+         lhs.bounds() == rhs.bounds() &&
+         lhs.work_area() == rhs.work_area() &&
+         lhs.device_scale_factor() == rhs.device_scale_factor() &&
+         lhs.rotation() == rhs.rotation() &&
+         lhs.touch_support() == rhs.touch_support();
+}
+
+}  // namespace gfx
+
+#endif  // UI_GFX_TEST_DISPLAY_UTIL_H_