ScreenWin Testability and Restructuring

ui/gfx/win/display_manager_observer.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GFX_WIN_DISPLAY_MANAGER_CHANGE_OBSERVER_H_
+#define UI_GFX_WIN_DISPLAY_MANAGER_CHANGE_OBSERVER_H_
+
+#include <vector>
+
+#include "ui/gfx/gfx_export.h"
+
+namespace gfx {
+namespace win {
+
+class ScreenWinDisplay;
+
+class GFX_EXPORT DisplayManagerObserver {
+ public:
+  virtual void OnDisplaysChanged(
+      const std::vector<gfx::win::ScreenWinDisplay> old_screen_win_displays,

[oshima, 2016/01/30 00:10:33]

&

[robliao, 2016/01/30 01:23:52]

Done.

+      const std::vector<gfx::win::ScreenWinDisplay> new_screen_win_displays) =

[oshima, 2016/01/30 00:10:33]

&

and indent

[robliao, 2016/01/30 01:23:52]

An indent shouldn't be necessary here as it's just the next item in the argument
list.

The 0 below is part of the assignment expression, which means a 4 space indent
from the start of the expression.

[oshima, 2016/02/01 19:07:37]

git cl indent moves the argument to the next line. If you don't like it, you may
keep it.

[robliao, 2016/02/01 21:35:04]

Sounds good. I think this is clearer this way as the = 0 is less important than
the args. This sounds like a bug in git cl indentation is I would expect it to
break at a higher syntactic level.

+      0;
+
+ protected:
+  virtual ~DisplayManagerObserver() = default;
+};
+
+}  // namespace win
+}  // namespace gfx
+
+#endif  // UI_GFX_WIN_DISPLAY_MANAGER_OBSERVER_H_