Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1639613002: Block two retired DigiCert intermediates (Closed)

Created:
4 years, 11 months ago by Ryan Sleevi
Modified:
4 years, 11 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Block two retired DigiCert intermediates Add two retired DigiCert intermediates to the certificate blacklist. BUG=none R=davidben@chromium.org Committed: https://crrev.com/358b4c8e47ceba49367c5abbf5de027039db1531 Cr-Commit-Position: refs/heads/master@{#371435}

Patch Set 1 #

Total comments: 2

Patch Set 2 : And fix links too #

Patch Set 3 : Missing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -60 lines) Patch
M net/cert/cert_verify_proc_blacklist.inc View 1 2 3 chunks +9 lines, -1 line 0 comments Download
A net/data/ssl/blacklist/159ca03a88897c8f13817a212629df84ce824709492b8c9adb8e5437d2fc72be.pem View 1 chunk +26 lines, -0 lines 0 comments Download
M net/data/ssl/blacklist/README.md View 1 3 chunks +70 lines, -59 lines 0 comments Download
A net/data/ssl/blacklist/b8c1b957c077ea76e00b0f45bff5ae3acb696f221d2e062164fe37125e5a8d25.pem View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ryan Sleevi
Hopefully easy rubberstamp :)
4 years, 11 months ago (2016-01-25 23:17:32 UTC) #1
davidben
lgtm https://codereview.chromium.org/1639613002/diff/1/net/cert/cert_verify_proc_blacklist.inc File net/cert/cert_verify_proc_blacklist.inc (right): https://codereview.chromium.org/1639613002/diff/1/net/cert/cert_verify_proc_blacklist.inc#newcode30 net/cert/cert_verify_proc_blacklist.inc:30: 0xf9, 0x92, 0xaa, 0x51, 0x0a, 0x62, 0x80, 0xb7, ...
4 years, 11 months ago (2016-01-25 23:21:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639613002/20001
4 years, 11 months ago (2016-01-25 23:34:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/121564) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-25 23:47:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639613002/40001
4 years, 11 months ago (2016-01-26 01:46:21 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 03:08:28 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 03:09:26 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/358b4c8e47ceba49367c5abbf5de027039db1531
Cr-Commit-Position: refs/heads/master@{#371435}

Powered by Google App Engine
This is Rietveld 408576698