Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1639593002: Add cross platform Bluetooth testing fixture for Windows. (Closed)

Created:
4 years, 11 months ago by gogerald
Modified:
4 years, 10 months ago
Reviewers:
scheib, gogerald1
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cross platform Bluetooth testing fixture for Windows. This CL is the first step to implement GATT service in Chrome for Windows by using cross platform testing fixture. BUG=579202

Patch Set 1 : #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -6 lines) Patch
M device/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +1 line, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_test_win.h View 1 chunk +50 lines, -0 lines 6 comments Download
A device/bluetooth/test/bluetooth_test_win.cc View 1 chunk +57 lines, -0 lines 2 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gogerald1
Hey Vincent, PTAL of this CL, Thanks.
4 years, 11 months ago (2016-01-25 23:41:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639593002/20001
4 years, 11 months ago (2016-01-26 03:40:43 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/136153)
4 years, 11 months ago (2016-01-26 05:08:04 UTC) #8
scheib
Note that this patch is from your @google.com account. Looking good. Please do speak up ...
4 years, 11 months ago (2016-01-26 05:29:27 UTC) #9
gogerald1
4 years, 11 months ago (2016-01-26 19:33:26 UTC) #10
Thanks for review, agree with you. At present, all OS related operations have
been done in BluetoothTaskManagerWin asynchronously. GATT service implementation
will also abide by this rule.

Please check the address of your comments in CL
https://codereview.chromium.org/1632123003/.

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_win.cc (right):

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_win.cc:13: void BluetoothTestWin::SetUp()
{}
On 2016/01/26 05:29:26, scheib wrote:
> Remove Setup & TearDown if unneeded.

The reason I override these interfaces is to explicitly say do not use super
class SetUp and TearDown.

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_win.h (right):

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_win.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/01/26 05:29:27, scheib wrote:
> 2016

Done.

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_win.h:35: scoped_refptr<BluetoothAdapter>
adapter_;
On 2016/01/26 05:29:27, scheib wrote:
> BluetoothTest::adapter_ exists with this type already.

Done.

https://codereview.chromium.org/1639593002/diff/20001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_win.h:40: BluetoothAdapterWin*
adapter_Win_;
On 2016/01/26 05:29:27, scheib wrote:
> adapter_Win_ -> adapter_win_

Done.

Powered by Google App Engine
This is Rietveld 408576698