Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1639563003: Renames WindowManagerConfig to FrameDecorationValues and moves to Display (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames WindowManagerConfig to FrameDecorationValues and moves to Display I also nuked WindowManager::GetConfig() as the information has moved onto Display. BUG=548429 566155 R=ben@chromium.org Committed: https://crrev.com/f5ece4e1c7330411660934f59b360af7c7b2263d Cr-Commit-Position: refs/heads/master@{#371563}

Patch Set 1 #

Patch Set 2 : comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -118 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.h View 3 chunks +7 lines, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_manager_delegate.h View 2 chunks +14 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 2 chunks +0 lines, -12 lines 0 comments Download
M components/mus/public/interfaces/window_manager_constants.mojom View 2 chunks +10 lines, -1 line 1 comment Download
M components/mus/public/interfaces/window_tree.mojom View 3 chunks +6 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 4 chunks +85 lines, -28 lines 0 comments Download
M components/mus/ws/forwarding_window_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/forwarding_window_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 4 chunks +8 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 3 chunks +14 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mash/wm/window_manager_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M mash/wm/window_manager_impl.cc View 4 chunks +20 lines, -41 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M ui/views/mus/screen_mus.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 4 chunks +34 lines, -3 lines 0 comments Download
A ui/views/mus/screen_mus_delegate.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 3 chunks +6 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 4 chunks +6 lines, -20 lines 0 comments Download
M ui/views/mus/window_manager_frame_values.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 11 months ago (2016-01-25 23:51:10 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1639563003/diff/20001/components/mus/public/interfaces/window_manager_constants.mojom File components/mus/public/interfaces/window_manager_constants.mojom (right): https://codereview.chromium.org/1639563003/diff/20001/components/mus/public/interfaces/window_manager_constants.mojom#newcode57 components/mus/public/interfaces/window_manager_constants.mojom:57: FrameDecorationValues frame_decoration_values; It does strike me as a ...
4 years, 11 months ago (2016-01-26 19:18:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639563003/20001
4 years, 11 months ago (2016-01-26 19:30:03 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 19:40:43 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:43:20 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f5ece4e1c7330411660934f59b360af7c7b2263d
Cr-Commit-Position: refs/heads/master@{#371563}

Powered by Google App Engine
This is Rietveld 408576698