[Autofill] Fill from the last digits when filling a phone number with a maximum length.

components/autofill/core/browser/autofill_field_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_field.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 241 matching lines @@
 
   // Credit card related field.
   field.set_heuristic_type(CREDIT_CARD_NUMBER);
   AutofillField::FillFormField(field, ASCIIToUTF16("4111111111111111"), "en-US",
                                "en-US", &field);
 
   // Verify that the field is filled.
   EXPECT_EQ(ASCIIToUTF16("4111111111111111"), field.value);
 }
 
 TEST(AutofillFieldTest, FillPhoneNumber) {

[Mathieu, 2016/01/26 14:43:02]

Maybe I'm spoiled by your other changes, but can we refactor these tests to be
done with TestCase structs? Sounds like HtmlType, value to fill, expected value,
max_length are the things that keep coming back from test to test.

It will give us velocity later on.

[sebsg, 2016/01/26 23:56:26]

It's a good habit to take. It's so much easier to understand and to add tests.
Plus it made me realize a couple of improvements that could be made. Plus I
added test cases. Thanks!

[Mathieu, 2016/01/27 14:30:49]

Thanks!

[sebsg, 2016/01/27 21:01:21]

Acknowledged.

   AutofillField field;
   field.SetHtmlType(HTML_TYPE_TEL_LOCAL_PREFIX, HtmlFieldMode());
 
   // Fill with a non-phone number; should fill normally.
   AutofillField::FillFormField(
       field, ASCIIToUTF16("Oh hai"), "en-US", "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("Oh hai"), field.value);
 
   // Fill with a phone number; should fill just the prefix.
   AutofillField::FillFormField(
       field, ASCIIToUTF16("5551234"), "en-US", "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("555"), field.value);
 
-  // Now reset the type, and set a max-length instead.
+  // Now reset the type, and set a max-length the size of a suffix.
   field.SetHtmlType(HTML_TYPE_UNSPECIFIED, HtmlFieldMode());
   field.set_heuristic_type(PHONE_HOME_NUMBER);
   field.max_length = 4;
 
   // Fill with a phone-number; should fill just the suffix.
   AutofillField::FillFormField(
       field, ASCIIToUTF16("5551234"), "en-US", "en-US", &field);
   EXPECT_EQ(ASCIIToUTF16("1234"), field.value);
+
+  // Now reset the type, and set a max-length of 10.
+  field.SetHtmlType(HTML_TYPE_UNSPECIFIED, HtmlFieldMode());

[Mathieu, 2016/01/26 14:43:02]

HTML_TYPE_TEL? 

https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[sebsg, 2016/01/26 23:56:26]

Done.

+  field.set_heuristic_type(PHONE_HOME_WHOLE_NUMBER);
+  field.max_length = 10;
+
+  // Fill with a whole phone number including country code. The number should
+  // fill without the country code.
+  AutofillField::FillFormField(field, ASCIIToUTF16("15141254578"), "en-US",
+                               "en-US", &field);
+  EXPECT_EQ(ASCIIToUTF16("5141254578"), field.value);
 }
 
 TEST(AutofillFieldTest, FillSelectControlByValue) {
   std::vector<const char*> kOptions = {
       "Eenie", "Meenie", "Miney", "Mo",
   };
   AutofillField field(GenerateSelectFieldWithOptions(kOptions, kOptions.size()),
                       base::string16());
 
   // Set semantically empty contents for each option, so that only the values
@@ skipping 506 matching lines @@
     index = kBadIndex;
     ret = AutofillField::FindValueInSelectControl(
         field, UTF8ToUTF16("NoVaScOtIa"), &index);
     EXPECT_TRUE(ret);
     EXPECT_EQ(2U, index);
   }
 }
 
 }  // namespace
 }  // namespace autofill