Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1639553002: Fix RSAPrivateKey::ExportPrivateKey documentation. (Closed)

Created:
4 years, 11 months ago by davidben
Modified:
4 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RSAPrivateKey::ExportPrivateKey documentation. It's a PKCS#8 PrivateKeyInfo blob, not a PKCS#1 RSAPrivateKey. BUG=none Committed: https://crrev.com/8131e3eb23a764c79113fd71f52ca127018527b7 Cr-Commit-Position: refs/heads/master@{#371377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M crypto/rsa_private_key.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
davidben
4 years, 11 months ago (2016-01-25 23:39:20 UTC) #2
Ryan Sleevi
lgtm
4 years, 11 months ago (2016-01-25 23:41:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639553002/1
4 years, 11 months ago (2016-01-25 23:43:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 00:29:04 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:30:30 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8131e3eb23a764c79113fd71f52ca127018527b7
Cr-Commit-Position: refs/heads/master@{#371377}

Powered by Google App Engine
This is Rietveld 408576698