scripts/make_mac_assembly.sh - Issue 1639543006: ICU 56 step 6: Check in the pre-built ICU data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/make_mac_assembly.sh

Issue 1639543006: ICU 56 step 6: Check in the pre-built ICU data (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@56local_patches

Patch Set: address review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/make_mac_assembly.sh

diff --git a/scripts/make_mac_assembly.sh b/scripts/make_mac_assembly.sh

old mode 100644

new mode 100755

index 8ca593e7008ee2eb04a5b0d342e9924bcde457b5..c25867508cfedb172ebd069ad7f7281993a7d482

--- a/scripts/make_mac_assembly.sh

+++ b/scripts/make_mac_assembly.sh

@@ -3,10 +3,12 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-ICUROOT="$(dirname $0)/.."

+ICUROOT="$(dirname "$0")/.."

LINUX_SOURCE="${ICUROOT}/linux/icudtl_dat.S"

MAC_SOURCE="${ICUROOT}/mac/icudtl_dat.S"

+echo "Generating ${MAC_SOURCE} from ${LINUX_SOURCE}"

# Linux uses 'icudt${MAJOR VERSION}_dat' while Mac has "_" prepended to it.

ICUDATA_SYMBOL="_$(head -1 ${LINUX_SOURCE} | cut -d ' ' -f 2)"

@@ -23,3 +25,4 @@ PREAMBLE

PREAMBLE_LENGTH=$(($(egrep -n '^icudt' ${LINUX_SOURCE} | cut -d : -f 1) + 1))

tail -n +${PREAMBLE_LENGTH} ${LINUX_SOURCE} >> ${MAC_SOURCE}

+echo "Done with generating ${MAC_SOURCE}"

« no previous file with comments | « scripts/make_data.sh ('k') | scripts/make_n_copy_data.sh » ('j') | no next file with comments »