Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1639533003: Record static constant public fields. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Serialize only constant constructors. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index 9bcb40d41d4238ace4ccd281c2253ada001c8125..1f24248188d81872da669170565c511045eb164d 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -64,6 +64,19 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
node.typeParameters?.typeParameters?.length ?? 0);
if (cls != null) {
for (ClassMember member in node.members) {
+ if (member is FieldDeclaration &&
+ member.isStatic &&
+ member.fields.isConst) {
+ for (VariableDeclaration field in member.fields.variables) {
+ String name = field.name.name;
+ if (isPublic(name)) {
+ cls.constMembers.add(new UnlinkedPublicNameBuilder(
+ name: name,
+ kind: ReferenceKind.constField,
+ numTypeParameters: 0));
+ }
+ }
+ }
if (member is MethodDeclaration &&
member.isStatic &&
!member.isGetter &&
@@ -71,17 +84,17 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
!member.isOperator) {
String name = member.name.name;
if (isPublic(name)) {
- cls.executables.add(new UnlinkedPublicNameBuilder(
+ cls.constMembers.add(new UnlinkedPublicNameBuilder(
name: name,
kind: ReferenceKind.staticMethod,
numTypeParameters:
member.typeParameters?.typeParameters?.length ?? 0));
}
}
- if (member is ConstructorDeclaration) {
+ if (member is ConstructorDeclaration && member.constKeyword != null) {
String name = member.name != null ? member.name.name : '';
if (isPublic(name)) {
- cls.executables.add(new UnlinkedPublicNameBuilder(
+ cls.constMembers.add(new UnlinkedPublicNameBuilder(
name: name,
kind: ReferenceKind.constructor,
numTypeParameters: 0));
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698