Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 163953011: [Chromoting] Update jscompile target to use JS files from gypi. (Closed)

Created:
6 years, 10 months ago by garykac
Modified:
6 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

[Chromoting] Update jscompile target to use JS files from gypi. The old version parses the main.html file to get the list of JS files to verify. Since we're moving to auto-generate this file, we can safely get the Js files from the same gypi since that's the same source being used to generate the HTML file. This also adds the WCS sandbox files to the list of JS files being checked -- they were not being checked as part of the old target because they are not used in the main.html file. BUG= R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251446

Patch Set 1 #

Patch Set 2 : Revert to single list of wcs js files #

Patch Set 3 : Update gyp file (wcs sandbox) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -112 lines) Patch
M remoting/remoting.gyp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
D remoting/tools/htmlcompile.py View 1 chunk +0 lines, -79 lines 0 comments Download
A remoting/tools/jscompile.py View 1 chunk +49 lines, -0 lines 0 comments Download
M remoting/webapp/js_proto/remoting_proto.js View 1 chunk +21 lines, -0 lines 0 comments Download
D remoting/webapp/wcs_iq_client_proto.js View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
garykac
6 years, 10 months ago (2014-02-14 01:13:59 UTC) #1
Jamie
lgtm
6 years, 10 months ago (2014-02-14 02:09:02 UTC) #2
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 10 months ago (2014-02-14 19:19:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/163953011/50001
6 years, 10 months ago (2014-02-14 19:22:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 20:49:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264566
6 years, 10 months ago (2014-02-14 20:49:10 UTC) #6
garykac
6 years, 10 months ago (2014-02-15 00:20:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r251446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698